-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow user to change status bar color based on mode #1529
Conversation
I changed the colors in the readme to be a bit darker vs the ones in the gif |
Merging this since it is pretty straight forward and behind a config flag! |
@@ -216,6 +220,16 @@ class ConfigurationClass { | |||
startInInsertMode = false; | |||
|
|||
/** | |||
* Start in insert mode? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to update the docstring here. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looking out for me :)
@@ -14,6 +14,10 @@ export interface IHandleKeys { | |||
[key: string]: boolean; | |||
} | |||
|
|||
export interface IStatusBarColors { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can actually do a more precise type here e.g.
interfcae IStatusBarColors {
normal: string,
visual: string,
// ...
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For super mega bonus points you could use TypeScript's mapped types to ENSURE that every mode has a color by mapping from our ModeNames object. Sort of like this:
interface IStatusBarColors { [Key in keyof ModeNames]: string }
Mapped types are awesome.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yes that is a good idea instead of string, string for sure
And the number of plugins we've implemented grows again... 😁 This is almost totally fine. I only have one problem... .... ... YOUR COLOR SCHEME JESUS MAN HOW DO YOU WORK LIKE THAT |
You have never used solarized dark? |
Nah I'm on Monokai, which makes my IDE look like Sublime to the untrained eye... |
It doesn't work on the latest version of Also the key names are different: "workbench.colorCustomizations": {
"statusBar.background": "#5fb3b3",
"statusBar.noFolderBackground": "#5fb3b3",
"statusBar.debuggingBackground": "#5fb3b3",
} |
I used this
taken from VS Market Place
|
I am ok opening this now since it is off by default and behind a config flag. We can either wait on it or just release it now and change that single function in the future when vscode changes the way this is done...
fixes #1056